Skip to content

ci(sign): Fix signing in Windows #12145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
me-no-dev merged 1 commit into from
Dec 16, 2025
Merged

ci(sign): Fix signing in Windows #12145

me-no-dev merged 1 commit into from
Dec 16, 2025
+8 −10

Conversation

@lucasssvaz
Copy link
Member

@lucasssvaz lucasssvaz commented Dec 16, 2025

Description of Change

This pull request updates the Windows binary signing process in the build_py_tools.yml GitHub Actions workflow. The manual PowerShell script for signing is replaced with the standardized espressif/release-sign GitHub Action, which integrates with Azure Key Vault for certificate management.

CI/CD Workflow Improvements:

  • Replaced the custom PowerShell signing script with the espressif/release-sign GitHub Action, leveraging Azure Key Vault secrets for more secure and maintainable binary signing on Windows. (.github/workflows/build_py_tools.yml)

Test Scenarios

Will test after merge in open PR.

@lucasssvaz lucasssvaz requested a review from me-no-dev December 16, 2025 19:26
@lucasssvaz lucasssvaz self-assigned this Dec 16, 2025
@lucasssvaz lucasssvaz added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c97c52a

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Dec 16, 2025
@me-no-dev me-no-dev merged commit bc11afd into master Dec 16, 2025
20 of 21 checks passed
@me-no-dev me-no-dev deleted the fix/windows_sign branch December 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels

Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucasssvaz @me-no-dev